schreifuchs
schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-16 09:17:12 +02:00
feat(pierre): add diff chunking and configurable review settings

Ignoring the potential error return from strings.CutSuffix might mask issues if the provided bitbucket BaseURL is malformed or does not match expected suffix patterns.

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-16 09:17:12 +02:00
feat(pierre): add diff chunking and configurable review settings

Using fmt.Print inside the chat response function pollutes standard output with side effects and mixes concerns between data processing and logging, making the code harder to maintain.

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-16 09:17:12 +02:00
feat(pierre): add diff chunking and configurable review settings

Using InsecureSkipVerify: true bypasses crucial SSL certificate validation, opening a potential security vulnerability (Man-in-the-Middle attacks) if the baseURL is not fully trusted.

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-16 09:11:42 +02:00
feat(pierre): add diff chunking and configurable review settings

Test comment from worker

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-16 09:03:50 +02:00
feat(pierre): add diff chunking and configurable review settings

Test comment from worker

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:53:12 +02:00
feat(pierre): add diff chunking and configurable review settings

Reading the entire diff into memory using io.ReadAll(diff) can cause excessive memory usage if a pull request has a very large diff; consider streaming or limiting the read size.

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:46:40 +02:00
feat(pierre): add diff chunking and configurable review settings

Test comment from worker

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:30:07 +02:00
feat(pierre): add diff chunking and configurable review settings

Test comment from worker

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:21:37 +02:00
feat(pierre): add diff chunking and configurable review settings

File: /tmp/pr-review-2253999896/internal/pierre/resource.go, Line: 11

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:21:37 +02:00
feat(pierre): add diff chunking and configurable review settings

File: /tmp/pr-review-2253999896/internal/gitadapters/bitbucket/controller.go, Line: 10

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:21:37 +02:00
feat(pierre): add diff chunking and configurable review settings

File: /tmp/pr-review-2253999896/internal/chatter/gemini.go, Line: 150

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:21:37 +02:00
feat(pierre): add diff chunking and configurable review settings

File: /tmp/pr-review-2253999896/internal/pierre/review.go, Line: 34

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:21:36 +02:00
feat(pierre): add diff chunking and configurable review settings

File: /tmp/pr-review-2253999896/internal/chatter/openai.go, Line: 25

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:18:11 +02:00
feat(pierre): add diff chunking and configurable review settings

Test review from pierre-bot test

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:15:27 +02:00
feat(pierre): add diff chunking and configurable review settings

File: internal/chatter/openai.go, Line: 125

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:15:27 +02:00
feat(pierre): add diff chunking and configurable review settings

File: internal/chatter/openai.go, Line: 32

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:15:27 +02:00
feat(pierre): add diff chunking and configurable review settings

File: internal/chatter/ollama.go, Line: 90

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:15:27 +02:00
feat(pierre): add diff chunking and configurable review settings

File: internal/chatter/ollama.go, Line: 32

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:15:27 +02:00
feat(pierre): add diff chunking and configurable review settings

File: internal/chatter/gemini.go, Line: 143

schreifuchs commented on pull request schreifuchs/pierre-bot#2 2026-06-15 15:15:27 +02:00
feat(pierre): add diff chunking and configurable review settings

File: internal/chatter/gemini.go, Line: 156